Skip to content

Comments

Use server URL#237

Merged
VicDeo merged 1 commit intomasterfrom
use-server-url
Feb 9, 2016
Merged

Use server URL#237
VicDeo merged 1 commit intomasterfrom
use-server-url

Conversation

@LukasReschke
Copy link
Member

Required for the auth changes in core. PR coming there as well soon.

@VicDeo Mind testing whether it still works currently? If yes then please merge and I can finish the core PR 😄

Required for the auth changes in core. PR coming there as well.
@LukasReschke LukasReschke added this to the 9.0-current milestone Feb 9, 2016
@LukasReschke
Copy link
Member Author

Basically I do a jquery.load in the admin page of ownCloud since we need to set the Authorization header. This means that the URI used will be the one of ownCloud => The API requests failed.

@@ -1,4 +1,7 @@
<link rel="stylesheet" href="<?=$this->uri() . '/pub/' . $this->asset('css/main.css')?>" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LukasReschke is this really needed here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately yes 😞

Everything in the head section is ignored when using jquery.load as done in owncloud/core#22255. If you have a cleaner solution I'm happy for suggestions 😄

@VicDeo
Copy link
Member

VicDeo commented Feb 9, 2016

works, merging 👍

@VicDeo VicDeo closed this Feb 9, 2016
@VicDeo VicDeo reopened this Feb 9, 2016
VicDeo added a commit that referenced this pull request Feb 9, 2016
@VicDeo VicDeo merged commit 3b67565 into master Feb 9, 2016
@VicDeo VicDeo deleted the use-server-url branch February 9, 2016 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants