Skip to content

Comments

Web UI#217

Merged
VicDeo merged 8 commits intomasterfrom
web
Feb 5, 2016
Merged

Web UI#217
VicDeo merged 8 commits intomasterfrom
web

Conversation

@VicDeo
Copy link
Member

@VicDeo VicDeo commented Jan 20, 2016

REQUIREMENTS

  • the updater has to have it's own html layout, the integration with the core admin page will be a simple link to open the index within the updater, no json integration or what so ever

TODO:

  • authorization/admin privileges check; Moved to Web UI Authentication #220
  • pass a path to oc instance somehow (For now we agreed that it always will be updater subdirectory and the only legit place to search for OC files is one dir above the file updater/index.php)

@VicDeo VicDeo added this to the 9.0-current milestone Jan 20, 2016
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs fixing 🙈

@karlitschek
Copy link

can't we do it without an .htaccess file? This is fragile and won't work in a lot of cases

@VicDeo
Copy link
Member Author

VicDeo commented Jan 25, 2016

@karlitschek this one is pushed unintentionally and will be removed later.
But the top-level htaccess needs to be changed anyway because Web UI is not accessible currently due to an url rewrite from domain.tld/updater/index.php to domain.tld/index.php/apps/updater/.

@karlitschek
Copy link

@VicDeo O.K.
I think we should call the updater web ui with relative urls only and don't rely on any routing or redirects or rewriting. All this stuff might not work.

@VicDeo VicDeo changed the title Quick-n-dirty Web UI. To be improved [WIP] Web UI Jan 25, 2016
@VicDeo VicDeo force-pushed the web branch 2 times, most recently from 6b61727 to 45bbf2f Compare January 27, 2016 16:01
@VicDeo
Copy link
Member Author

VicDeo commented Jan 27, 2016

@DeepDiver1975 hardcoded path is fixed.
Do you have any objections on merging this PR to keep going forward with small steps?

@DeepDiver1975
Copy link
Member

But the top-level htaccess needs to be changed anyway because Web UI is not accessible currently due to an url rewrite from domain.tld/updater/index.php to domain.tld/index.php/apps/updater/.

why is there a rewrite necesssary?

the new updater will be accessible using domain.tld/updater/index.php

I miss something I guess

@DeepDiver1975
Copy link
Member

there is something wrong in loading the assets when accessing the updater in a subfolder

bildschirmfoto von 2016-01-28 13-36-56

@DeepDiver1975
Copy link
Member

We need to switch all occ command invocations to actual web requests to the ownCloud instance.
We cannot spawn php processes within a web request.

Sounds like we need a web executor for occ commands ...

@karlitschek @PVince81 @icewind1991 @VicDeo ideas? objections?

@VicDeo
Copy link
Member Author

VicDeo commented Jan 28, 2016

@DeepDiver1975

why is there a rewrite necesssary?
the new updater will be accessible using domain.tld/updater/index.php
I miss something I guess

We agreed (in Skype) that it will be an URL like this:
domain.tld/updater or domain.tld/some_path/updater

This approach requires an additional rewrite condition
RewriteCond %{REQUEST_FILENAME} !/updater/
here https://github.com/owncloud/core/blob/master/.htaccess#L61

This is also the answer to the assets loading issue

@VicDeo
Copy link
Member Author

VicDeo commented Jan 28, 2016

@DeepDiver1975

We need to switch all occ command invocations to actual web requests to the ownCloud instance.
We cannot spawn php processes within a web request.
Sounds like we need a web executor for occ commands ...

In this case I'd stay away from Symfony Console Application for web UI and move all logic from commands to abstraction layer leaving only IO operations inplace.

@DeepDiver1975
Copy link
Member

In this case I'd stay away from Symfony Console Application for web UI and move all logic from commands to abstraction layer leaving only IO operations inplace.

I see no need for this since we only need two different implementation in the updater for the occ commands - one using php process invocation and one which is performing a web request to the owncloud instance

@VicDeo
Copy link
Member Author

VicDeo commented Jan 28, 2016

OCC command list:
maintenance:mode
upgrade
status
config:list
app:disable
app:enable
app:getpath
app:list

@karlitschek
Copy link

@VicDeo Can we also have commands for

  • Check if an update is available
  • Download a new owncloud release only
  • Generate a backup of the current installation

@DeepDiver1975
Copy link
Member

Check if an update is available
Download a new owncloud release only

these are commands which are implemented within the updater - nothing which we want to rely on owncloud core

@DeepDiver1975
Copy link
Member

Generate a backup of the current installation

same from my pov

@karlitschek
Copy link

ahh sorry. maybe i misunderstood. :-) I mean that we need this in the updater. not in the core of course.

@VicDeo
Copy link
Member Author

VicDeo commented Jan 28, 2016

@karlitschek yes, this is a list of commands that we use with core occ command.

@VicDeo VicDeo force-pushed the web branch 7 times, most recently from eb525b4 to 7e14956 Compare February 1, 2016 22:08
@VicDeo VicDeo force-pushed the web branch 3 times, most recently from a9f8994 to f936012 Compare February 4, 2016 21:09
VicDeo added a commit that referenced this pull request Feb 5, 2016
@VicDeo VicDeo merged commit 508ddb3 into master Feb 5, 2016
@VicDeo VicDeo changed the title [WIP] Web UI Web UI Feb 5, 2016
@DeepDiver1975 DeepDiver1975 deleted the web branch February 6, 2016 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants