Conversation
|
@Kondou-ger Build failed |
|
;-) |
|
@Kondou-ger @butonic rebase required - THX |
|
Also here too, can the referred people take a look at this? cc @icewind1991 @LukasReschke @bartv2 @butonic @DeepDiver1975 |
|
👍 looks good |
Conflicts: lib/helper.php lib/image.php
Conflicts: lib/base.php lib/util.php
Conflicts: lib/files/view.php
Conflicts: lib/app.php lib/cache/file.php lib/cache/fileglobal.php lib/helper.php lib/installer.php
Conflicts: lib/templatelayout.php
|
Test passed. |
Conflicts: lib/user/http.php
|
Test passed. |
Conflicts: lib/base.php lib/private/app.php lib/private/connector/sabre/file.php lib/private/helper.php lib/vcategories.php
|
Test passed. |
|
I'm actually not sure if this is the right approach. == and === makes a difference in PHP. You can't always assume that the logic doesn'T break if you replace this automatically with a script. Sorry but we have to do this manually or keep it as is is. Closing this for now. |
That's why this has to be tested 😉 |
|
Sure. But it's a challenge to do a full test. :-) I think we have to do this step by step :-) |
6 participants
Mostly automated. Did some testing.
More testing would be nice.
cc @tomneedham @bartv2 @MTGap @karlitschek @LukasReschke @icewind1991 @DeepDiver1975 @tanghus @eMerzh