Fixed disappearing of share info in file view#26534
Merged
PVince81 merged 1 commit intoowncloud:masterfrom Nov 3, 2016
Merged
Conversation
|
@mjobst-necls, thanks for your PR! By analyzing the history of the files in this pull request, we identified @PVince81, @rullzer and @stweil to be potential reviewers. |
Contributor
|
👍 looks good, thanks! |
This was referenced Nov 3, 2016
Contributor
|
Backports: |
This was referenced Mar 3, 2017
Closed
Merged
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The share information got lost after rerendering the list entry. That was the case, because the data-share-types were not added back to the fileInfo on row creation.
Related Issue
#26241
Motivation and Context
It's a little bugfix, so I don't wanna write a big comment. The share information stays visible in the file list.
How Has This Been Tested?
Chrome (current) on Ubuntu 16.04
Screenshots (if appropriate):
Types of changes
Checklist:
I'm not sure how to implement this in a unit test. Any ideas?