[stable9.1] Tear down FS between cron jobs#26223
Merged
DeepDiver1975 merged 1 commit intostable9.1from Sep 30, 2016
Merged
Conversation
Because some cron jobs do not always properly clean up their FS usage and others might not clean up before setting up the FS, this could cause potential side effects. To make sure we exclude side effects, we tear down the FS between cron jobs.
|
@PVince81, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975, @butonic and @nickvergessen to be potential reviewers |
Contributor
Author
|
Member
|
👍 |
DeepDiver1975
pushed a commit
that referenced
this pull request
Sep 30, 2016
Because some cron jobs do not always properly clean up their FS usage and others might not clean up before setting up the FS, this could cause potential side effects. To make sure we exclude side effects, we tear down the FS between cron jobs.
DeepDiver1975
pushed a commit
that referenced
this pull request
Sep 30, 2016
Because some cron jobs do not always properly clean up their FS usage and others might not clean up before setting up the FS, this could cause potential side effects. To make sure we exclude side effects, we tear down the FS between cron jobs.
This was referenced Sep 30, 2016
PVince81
pushed a commit
that referenced
this pull request
Oct 4, 2016
…fb9ed273c15b245cc27 [stable9] Tear down FS between cron jobs (#26223)
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Because some cron jobs do not always properly clean up their FS usage
and others might not clean up before setting up the FS, this could
cause potential side effects.
To make sure we exclude side effects, we tear down the FS between cron
jobs.
Related Issue
Tentative fix for #25718
Motivation and Context
See issue details
How Has This Been Tested?
Ran cron.php and saw there was no new errors.
Note that the original issue isn't reproducible yet, so this is just an extra care.
Screenshots (if appropriate):
Types of changes
Checklist:
Backports
@DeepDiver1975 @butonic