Skip to content

Comments

Fix share indicator handling#25838

Merged
PVince81 merged 2 commits intomasterfrom
fix-share-type-indicator
Apr 24, 2017
Merged

Fix share indicator handling#25838
PVince81 merged 2 commits intomasterfrom
fix-share-type-indicator

Conversation

@PVince81
Copy link
Contributor

@PVince81 PVince81 commented Aug 17, 2016

Properly update the fileInfoModel with the updated share types, which
also updates the file list row indicator properly

Fixes #25311

  • Need to check performance impact because this code is sometimes called even when there are no changes
  • JS unit tests

@mention-bot
Copy link

@PVince81, thanks for your PR! By analyzing the annotation information on this pull request, we identified @blizzz, @rullzer and @schiessle to be potential reviewers

@SergioBertolinSG
Copy link
Contributor

Works fine 👍
Tested on chrome, firefox, safari, edge and ie11.

@DeepDiver1975
Copy link
Member

Again the Oracle Docker did not Start ....

@PVince81
Copy link
Contributor Author

Need to check performance impact because this code is sometimes called even when there are no changes

In general Backbone only fires change events if attributes are really changed. So setting the same attributes to the same value will not fire any change event so it should be fine.

@PVince81
Copy link
Contributor Author

Added unit tests

@butonic
Copy link
Contributor

butonic commented Apr 20, 2017

does not work with 10.0beta2

@PVince81
Copy link
Contributor Author

@butonic this isn't merged yet. Or did you patch 10.0beta2 with this PR to test it ?

@butonic
Copy link
Contributor

butonic commented Apr 21, 2017

yup, I patched 10.0beta2 and the bug was still there. double checked the code in the browser wasn't cached

Properly update the fileInfoModel with the updated share types, which
also updates the file list row indicator properly
@PVince81
Copy link
Contributor Author

You're right. Apparently the indicator only updates for local shares.

Could be related to the changes related to link shares related to multiple link changes.
Let me see if I can quickly fix this...

@PVince81 PVince81 force-pushed the fix-share-type-indicator branch from 0185c68 to 856c39c Compare April 21, 2017 14:33
@PVince81
Copy link
Contributor Author

Rebased, and added fix for link shares.

Please retest.

@butonic
Copy link
Contributor

butonic commented Apr 21, 2017

👍

@PVince81 PVince81 merged commit cba8b5d into master Apr 24, 2017
@PVince81 PVince81 deleted the fix-share-type-indicator branch April 24, 2017 07:47
@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Share indicator not appearing upon sharing, only after refresh

5 participants