Conversation
|
@PVince81, thanks for your PR! By analyzing the annotation information on this pull request, we identified @blizzz, @rullzer and @schiessle to be potential reviewers |
|
Works fine 👍 |
|
Again the Oracle Docker did not Start .... |
In general Backbone only fires change events if attributes are really changed. So setting the same attributes to the same value will not fire any change event so it should be fine. |
3f3ecc6 to
0185c68
Compare
|
Added unit tests |
|
does not work with 10.0beta2 |
|
@butonic this isn't merged yet. Or did you patch 10.0beta2 with this PR to test it ? |
|
yup, I patched 10.0beta2 and the bug was still there. double checked the code in the browser wasn't cached |
Properly update the fileInfoModel with the updated share types, which also updates the file list row indicator properly
|
You're right. Apparently the indicator only updates for local shares. Could be related to the changes related to link shares related to multiple link changes. |
0185c68 to
856c39c
Compare
|
Rebased, and added fix for link shares. Please retest. |
|
👍 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Properly update the fileInfoModel with the updated share types, which
also updates the file list row indicator properly
Fixes #25311