By analyzing the blame information on this pull request, we identified @icewind1991, @PVince81 and @butonic to be potential reviewers

All tests seem to pass, this seems to be a good solution. I'll need to test with Gallery to see if it has an impact, since there is a lot of duct tape to be able to retrieve the proper file.

rebased

👍 looks good

I'm worried that it might interfered with #21365

Maybe the normalization should use the flag that does not normalize UTF-8

or use trim($x, '/') instead

@oparoz did you get a chance to test this with gallery ?

@georgehrke please adjust and use the trim functions

AFAIK the double (or more) slashes were inside the string. trim will only cut off multiple slashes at the start and the end.

@georgehrke then can you at least set $keepUnicode to true just to be sure ? See https://github.com/owncloud/core/blob/master/lib/private/Files/Filesystem.php#L771

done

Thanks 👍

Did some testing with encryption and all still seem to work fine.

@georgehrke can you backport to 9.0 and 8.2 ? Make sure to remove the "keepUnicode" bit as it didn't exist there 😄

CC @cmonteroluque @DeepDiver1975

Rebased for CI

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.