Conversation
lib/private/Route/Router.php
Outdated
There was a problem hiding this comment.
This is required, because appinfo/ remains lowercase and therefor the class can not be PSR-4 loaded
|
Awesome stuff! Would it make sense to have all the php files in a src dir? Just so we don't mix CamelCase and lower case in the root app folder? |
nickvergessen
force-pushed
the
psr4-for-apps
branch
from
851eb06 to
8e58c2d
Compare
|
Done, also solves the hacky problemwith duplicated appinfo/. |
nickvergessen
force-pushed
the
psr4-for-apps
branch
from
8e58c2d to
ee3457a
Compare
| */ | ||
| protected static function registerAutoloading($app, $path) { | ||
| // Register on PSR-4 composer autoloader | ||
| $appNamespace = \OC\AppFramework\App::buildAppNamespace($app); |
There was a problem hiding this comment.
so we move everything in a subfolder called src? Fine with me, but want to point this out.
There was a problem hiding this comment.
Also good to document this ;)
There was a problem hiding this comment.
as explained below - let's name it lib
There was a problem hiding this comment.
Yes, I will drop an explanation mail as a response on @rullzer s mail to the mailing list once this is merged.
|
Looks good and looks clean! But awesome! 🎈 |
Originally we had all php files living in the subfolder lib - this is also reflected in the old class loader. |
It will with this PR live in |
And I say: let's name it |
|
Switched to lib/ and adjusted the app as well |
|
Tested (with the apps @nickvergessen already moved) and works like a charm! I agree we should add this to the docs and send to the ML. But very nice and cool stuff! 👍 |
|
Tested and works like a charm with old and new apps 👍 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
4 participants
Sample PR on an app: owncloud/announcementcenter#73
@DeepDiver1975 @rullzer @MorrisJobke
The following directories remain unchanged, since they should not contain namespaces classes and have hardcoded usage. Otherwise we would always need to check two directories: