Conversation
|
By analyzing the blame information on this pull request, we identified @nickvergessen to be a potential reviewer |
|
ping @jancborchardt |
|
what about the missing icons? |
|
The radio white: checked, disabled and checked+disabled are the same as the normal radio ones. The checkbox white checked+disabled is also the same as the normal one. Added the missing checkbox-mixed-disabled icon – also the same for both normal and white. |
5f19476 to
a271f7a
Compare
|
@Henni Any chance to get the code for your tests in a building block example app? To easily show what CSS building blocks are there and to easily test, if all is still working with a new version? |
|
@MorrisJobke I have already worked on such an example app. |
|
I think the png file isn't needed. beside that: 👍 |
|
@MorrisJobke We should probably remove all png files for checkboxes/radios. |
Not really, but adding unneeded files should be addressed in this PR ;) |
|
@MorrisJobke fixed. |
Squashing is always nice, but we now could squash on merge because GitHub supports it now :) |
|
👍 nice! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |

fixes #19741
fixes #19743
@jancborchardt I'm still missing some icons. Can you add them to this PR please?
Checkbox
Checkbox White
Radio
Radio White