Move data protection check to javascript#22054
Move data protection check to javascript#22054DeepDiver1975 merged 2 commits intoowncloud:masterfrom vincchan:vincchan/fix#20199
Conversation
|
By analyzing the blame information on this pull request, we identified @rullzer, @LukasReschke and @Xenopathic to be potential reviewers |
core/js/setupchecks.js
Outdated
There was a problem hiding this comment.
Debug code. Can be removed :)
core/js/config.php
Outdated
There was a problem hiding this comment.
please make the first letter of such variables lower case (it's by convention for PHP variables)
|
Code looks good otherwise |
|
Raised #22066 to wake up CI tests. @vincchan Thanks a lot for your contribution! Alternatively you can add a comment here where you state that this contribution is MIT licensed. Some more details about out pull request workflow can be found here: http://owncloud.org/code-reviews-on-github/ |
|
@PVince81 CLA has been sent to [email protected] thanks! |
|
@karlitschek Please confirm. THX. |
|
confirmed! Thanks a lot! |
|
CI passing at #22066 👍 for this changeset from me. Thanks Vincent 😄 🚀 |
|
👍 |
Move data protection check to javascript
|
Really 👎 for this. Checking if the .ocdata is not accessible is no proof if the datadir is protected. Most webserver setups out there are denying the access to those "dot" files by default. There is no guarantee that the datadir is protected by the assumption that the .ocdata is not accessible. |
ghost
mentioned this pull request
|
Raised #24987 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
6 participants
fixes #20199