Skip to content

Comments

Remove unneeded check if htaccess test file already exists#21479

Merged
DeepDiver1975 merged 1 commit intomasterfrom
fix-broken-state-in-htaccess-test
Jan 8, 2016
Merged

Remove unneeded check if htaccess test file already exists#21479
DeepDiver1975 merged 1 commit intomasterfrom
fix-broken-state-in-htaccess-test

Conversation

@MorrisJobke
Copy link
Contributor

How to reproduce:

  • run touch data/htaccesstest.txt
  • before: htaccess test in admin settings fails
  • after: htaccess test in admin settings works

cc @nickvergessen @LukasReschke @Xenopathic @RalfJung @KKyang @nodomain @mislav-eu @linucksrox @Jocko-plugout @nyklspree Please test :)

@MorrisJobke MorrisJobke force-pushed the fix-broken-state-in-htaccess-test branch from 6d6543b to 516a6d7 Compare January 6, 2016 12:45
@LukasReschke
Copy link
Member

Has been added with ad720c4 by @icewind1991 in 2012.

Works fine locally 👍

@icewind1991 Can you remember what this was about?

@icewind1991
Copy link
Contributor

No clue

@MorrisJobke
Copy link
Contributor Author

@rullzer @icewind1991 @PVince81 Mind a review? This is a easy one ;)

@icewind1991
Copy link
Contributor

👍

DeepDiver1975 added a commit that referenced this pull request Jan 8, 2016
…test

Remove unneeded check if htaccess test file already exists
@DeepDiver1975 DeepDiver1975 merged commit e60dddf into master Jan 8, 2016
@DeepDiver1975 DeepDiver1975 deleted the fix-broken-state-in-htaccess-test branch January 8, 2016 14:53
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Admin panel incorrectly warns about data/.htaccess not working

5 participants