fix files table CSS specificity issue causing multiselect bar overlap#2076
Merged
BernhardPosselt merged 2 commits intomasterfrom Mar 4, 2013
Merged
fix files table CSS specificity issue causing multiselect bar overlap#2076BernhardPosselt merged 2 commits intomasterfrom
BernhardPosselt merged 2 commits intomasterfrom
Conversation
Closed
Contributor
|
@jancborchardt I am so sorry, had in mind but missed it. I wanted to point out but the positioning elements in any app should be classified under specific ids or classes or else it screws up all other elements too, say the table in the PR I made #2065 screwed up the table for DatePicker too. What do you think? |
Contributor
|
Looks good in the files list. But for the trash bin it is still broken. Would be great if you could also have a look at it! Thanks! |
Contributor
|
@schiesbn Done. :) Again, really sorry for the mess. :| |
Contributor
|
Looks good, thanks for fixing it! 👍 |
Contributor
|
👍 |
BernhardPosselt
added a commit
that referenced
this pull request
Mar 4, 2013
fix files table CSS specificity issue causing multiselect bar overlap
Member
Author
|
@raghunayyar yeah, it was a good call to ID that table, for the reason of screwing with other elements you mentioned. Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2075
Check it out @schiesbn @raghunayyar @Raydiation
@raghunayyar if you introduce a new ID (#filestable) and CSS rule, make sure that you’re not overriding other rules. ;)