Skip to content

Comments

save excluded groups in json format #19510

Merged
DeepDiver1975 merged 1 commit intomasterfrom
json-grouplist-sharing-exclude
Oct 2, 2015
Merged

save excluded groups in json format #19510
DeepDiver1975 merged 1 commit intomasterfrom
json-grouplist-sharing-exclude

Conversation

@DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 added this to the 8.2-current milestone Oct 1, 2015
@karlitschek
Copy link
Contributor

great 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PVince81 this is the migration step 🙈

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why then not add it as an repair step? 🙈

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On-demand fixing is the new cool thing

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And leaves a lot of code just because it could be not fixed in a specific use case :(

@PVince81
Copy link
Contributor

PVince81 commented Oct 1, 2015

Works 👍

DeepDiver1975 added a commit that referenced this pull request Oct 2, 2015
@DeepDiver1975 DeepDiver1975 merged commit 8944cb5 into master Oct 2, 2015
@DeepDiver1975 DeepDiver1975 deleted the json-grouplist-sharing-exclude branch October 2, 2015 10:14
@LukasReschke
Copy link
Member

Regression: #19542

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exclude with groups cannot work with groups containing commas

5 participants