[IE8] Remove non-working ellipsis support#19496
Merged
Conversation
Contributor
Author
|
Note: I don't think it's worth wasting time trying to make ellipsis working in IE8, so for now there will be no ellipsis any more for long names. But at least now the sidebar hotspot works properly. |
This prevents the name element to be too wide, which would cause users to mistakenly click on it instead of the empty space when wanting to focus on a file for the sidebar. Also fixed the close button on the sidebar (make it appear)
MorrisJobke
force-pushed
the
ie8-filenamewidth-sickness
branch
from
2a2c78c to
9e66653
Compare
Contributor
|
You left one closing Works 👍 Many thanks for your effort on this. |
Contributor
Author
|
@MorrisJobke thanks |
Contributor
|
👍 |
butonic
added a commit
that referenced
this pull request
Oct 2, 2015
[IE8] Remove non-working ellipsis support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents the name element to be too wide, which would cause users
to mistakenly click on it instead of the empty space when wanting to
focus on a file for the sidebar.
Also fixed the close button on the sidebar (make it appear)
(I know the button looks shitty, but it's better than no button at all...)
Fixes #18619 (comment)
Please review @davitol @MorrisJobke @blizzz @rullzer @Henni