Add .checkbox class for new checkbox style#19329
Conversation
|
Now the checkboxes in the files list in IE8 are at the top left corner. Maybe we need some additional rules for IE8(maybe the ones from before all these checkbox changes) |
|
It's not only in IE8 ... it's also in FIrefox. |
|
I know that this is happening and it should be possible to fix this by adding the checkbox class to the checkboxes. I'll do this later. |
|
@MorrisJobke I just fixed the filelist checkboxes. |
|
A starting point for the new checkbox style. |
Henni
force-pushed
the
checkbox-class
branch
from
fa30e86 to
604f578
Compare
|
👍 WFM
|
There was a problem hiding this comment.
Why double dash? Is a single one not enough?
There was a problem hiding this comment.
This is the BEM naming convention. I would like to introduce such a convention for all owncloud core (or even app) css in the future. This may prevent issues like owncloud/notifications#16 and may allow us to remove a lot of the !important if we apply this methodology correctly.
|
Damn ... I was on the wrong branch -.- |
|
Yes. This looks a lot better and is usable with IE8 again 👍 |
|
@MorrisJobke I can't see the bugs you've found. 😿 Edit: I did not see your last comments 👍 |
|
Awesome. Really really thanks a lot @Henni for taking care of all the checkbox issues, much appreciated. \o/ |
Add .checkbox class for new checkbox style
|
Thanks a lot! |
|
@Henni you are awesome! Deserves another drink or two at the Munich meetup in November. ;) |
6 participants
I added the
.checkboxclass as discussed in #19304fixes #19304
Currently this class isn't used anywhere. The next step is to apply it to the checkboxes in core.
This PR also considers that IE8 doesn't support the pseudo-class selector
:checked.