Conversation
|
let me know if you need help from someone on that. Would be good to have this in today or tomorrow |
|
I can do this over the weekend. @karlitschek @jancborchardt |
|
@raghunayyar this would be great. Thanks |
|
@jancborchardt @karlitschek there will be some semantics changes (wherever we use check-boxes)for this because I can't assign a background to the check-box but it is assigned to the label along with it. Please check my commit for that matter. |
|
I'm fine with that. @jancborchardt What do you think? |
MorrisJobke
added
3 - To Review
2 - Developing
and removed
2 - Developing
3 - To Review
labels
|
Doesn't work on the login page in firefox:
|
|
Also looks weird in generated previews (with white background):
|
|
Activity settings on personal page:
|
|
It will not, that is what I mentioned. We manually style labels and checkboxes on the respective pages. So, we will have to update it there. I am waiting for a heads up for that. It is a bigger change than it looks. Cc @jancborchardt |
|
@raghunayyar so should we postpone to 9.0? |
|
@jancborchardt definitely, I will take care of this in core. cc @karlitschek |
|
@raghunayyar What do you mean? So no way to have this in the next week before feature freeze? |
|
@raghunayyar do you think you can manage it for next week? Let me know if you need help. |
|
My problem is, we don't style check-boxes, we style labels in front of them. This change needs to happen everywhere where we use check-boxes in core as well as apps. I will try my best to get this in next week. |
|
Thanks! Sorry to hear that this is more complex then expected |
|
Also, I need white checkboxes for login cc @jancborchardt |
|
@raghunayyar it’s fine if for IE8 (and other browsers where it’s difficult to get right) we just show the default checkboxes. But is it possible to fix this for modern browsers like Chrome, Firefox etc? Would be really awesome! :) I’ll add the white checkboxes right now. |
|
@raghunayyar added the white versions. |
|
@jancborchardt awesome, on it. |
|
WOAH, nice! Everything works :) 👍 @karlitschek everything done. Now just waiting for the required statuses to pass – before that it is impossible to press the merge button. |
|
@Henni this is really really awesome. \o/ |
jancborchardt
force-pushed
the
checkbox-style
branch
from
150ad65 to
d2d4cbc
Compare
|
@raghunayyar you did a merge instead of the needed rebase. I fixed that. Let’s see what the tests say … |
|
great guys !!!! |
|
Giant thanks to heroes @raghunayyar & @Henni! :) |
|
FYI, That line https://github.com/owncloud/core/pull/18735/files#diff-463c027b5536faafc395f8fd4d09792bR166 causes checkboxes to be invisible, as reported in #18619 (comment) and #19238 for example |
There was a problem hiding this comment.
How about adding an additional CSS class on the input when wanting to use the new style ?
This way the old checkboxes will still look as before instead of disappear. That would be a fallback solution.
There was a problem hiding this comment.
@PVince81 I thought about this, but this leads to additional code in the long-term.
In my opinion the way we have it now is the cleaner solution.
There was a problem hiding this comment.
but has the drawback of breaking checkboxes for every app out there, including third party app store apps including the functionality attached to them.
I'd vote for adding an additional class short-term and once all apps have been migrated to the new style we can make it global and remove the need for it.
There was a problem hiding this comment.
@PVince81 how do we get third party apps to migrate to the new style?
It is quite difficult to deprecate css.
BTW most apps and most checkboxes in core worked out of the box because they already had a label next the checkboxes.
There was a problem hiding this comment.
The same way as when deprecating JS/PHP functions: write documentation about how to migrate to the new way + email to mailing list.
In the worst case some apps will then look uglier instead of having broken functionality.
There was a problem hiding this comment.
The breaks were bound to happen as I mentioned in the PR itself but I am super glad they are being taken care asap by @Henni. I will also join during the weekend.
9 participants
@raghunayyar here are the icons if you want to have a stab at it. :) We should probably use them in 50% or 70% grey to fit better. I can also add them in white because we likely need that for the log in page checkbox.
cc @owncloud/designers