Conversation
Otherwise the headers from `JSONResponse` are gone and the Content-Type of the response would be `text/html` instead of `application/json; charset=utf-8`. This leads to broken scripts since we set the `nosniff` tag, furthermore this is very bad from a security PoV.
Contributor
|
👍 |
13 tasks
Member
|
👍 |
Contributor
There was a problem hiding this comment.
I love that we even had simply wrong unit tests. They just test exactly what is done and not what is wanted -> therefore write the test in a way you want to have a feature and not how the feature is.
|
🚀 Test PASSed. 🚀 |
|
The inspection completed: No new issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise the headers from
JSONResponseare gone and the Content-Type of the response would betext/htmlinstead ofapplication/json; charset=utf-8. This leads to broken scripts since we set thenosniffheader, furthermore this is very bad from a security PoV.Fixes itself.
@Raydiation @MorrisJobke