Shares can be created without uid_initiator #24981
Description
Steps to reproduce
- Create a share like this
$share = \OCP\Share::shareItem('file', 1234, 0, 'tester', \OCP\Constants::PERMISSION_ALL) - Login as user tester
Expected behaviour
User should be able to log in
Actual behaviour
Share 2.0 throws an exception because uid_initiator is null.
Exception trace:
() at /lib/private/Share20/Share.php:287
OC\Share20\Share->setSharedBy() at /lib/private/Share20/DefaultShareProvider.php:761
OC\Share20\DefaultShareProvider->createShare() at /lib/private/Share20/DefaultShareProvider.php:625
OC\Share20\DefaultShareProvider->getSharedWith() at /lib/private/Share20/Manager.php:950
OC\Share20\Manager->getSharedWith() at /apps/files_sharing/lib/MountProvider.php:61
OCA\Files_Sharing\MountProvider->getMountsForUser() at /lib/private/Files/Config/MountProviderCollection.php:76
OC\Files\Config\MountProviderCollection->OC\Files\Config\{closure}() at n/a:n/a
array_map() at /lib/private/Files/Config/MountProviderCollection.php:77
OC\Files\Config\MountProviderCollection->getMountsForUser() at /lib/private/Files/Filesystem.php:422
OC\Files\Filesystem::initMountPoints() at /lib/private/Files/Filesystem.php:370
OC\Files\Filesystem::init() at /lib/private/legacy/util.php:225
OC_Util::setupFS() at /tests/lib/TestCase.php:336
Test\TestCase::loginAsUser() at /apps/gallery/tests/_support/Helper/CoreTestCase.php:49
This change introduced the additional check, but things kept working for a while, so something else must have happened between April 15th at 8:26 and April 21st 8:22
Server configuration
PHP version: 7.0.7
ownCloud version: master
Updated from an older ownCloud or fresh install: rolling
Are you using encryption: no
Logs
ownCloud log (data/owncloud.log)
{"reqId":"y2CN+VfeG9bPeVR9lzjJ","remoteAddr":"","app":"no app in context","message":"getSharedWith: {\"id\":\"681\",\"share_type\":\"0\",\"share_with\":\"tester\",\"uid_owner\":\"sharer\",\"parent\":null,\"item_type\":\"file\",\"item_source\":\"301338\",\"item_target\":\"\/301338\",\"file_source\":\"301338\",\"file_target\":\"\/testimage-wide.png\",\"permissions\":\"23\",\"stime\":\"1465161408\",\"accepted\":\"0\",\"expiration\":null,\"token\":null,\"mail_send\":\"0\",\"uid_initiator\":null}","level":"debug","time":"2016-06-05T22:33:57+00:00","method":"--","url":"--","user":"tester"}