Skip to content

Comments

Backport DC-144 and DC-146#12327

Merged
DeepDiver1975 merged 4 commits into6from
backport-6/DC-144-146
Sep 25, 2025
Merged

Backport DC-144 and DC-146#12327
DeepDiver1975 merged 4 commits into6from
backport-6/DC-144-146

Conversation

@erikjv
Copy link
Contributor

@erikjv erikjv commented Sep 19, 2025

No description provided.

* [DC-146] Fix VFS checkbox in folder wizard

On the last page of the folder wizard, there is a checkbox to
select/deselect VFS. By default this is checked. The bug was that
after unchecking this checkbox, it could not be checked again.
This has now been fixed.

* Move checkbox handling to a slot

* [DC-166] Disable selective-sync when VFS is forced

Previously the checkbox to deselect VFS was not shown when VFS was
forced. This also caused the selective sync widget to be enabled. This
is now fixed: the checkbox is shown (and checked) when VFS is
availabled, but disabled when VFS is forced. This leaves it in the
checked state, but the user cannot deselect it.

---------

Co-authored-by: modSpike <[email protected]>
(cherry picked from commit 73493d0)
@update-docs
Copy link

update-docs bot commented Sep 19, 2025

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@CLAassistant
Copy link

CLAassistant commented Sep 19, 2025

CLA assistant check
All committers have signed the CLA.

@erikjv erikjv changed the base branch from master to 6 September 19, 2025 12:33
Copy link
Member

@DeepDiver1975 DeepDiver1975 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see review comment

@DeepDiver1975 DeepDiver1975 enabled auto-merge (squash) September 25, 2025 11:32
@DeepDiver1975 DeepDiver1975 merged commit 30f543e into 6 Sep 25, 2025
6 checks passed
@DeepDiver1975 DeepDiver1975 deleted the backport-6/DC-144-146 branch September 25, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants