Skip to content

Comments

[DC-82] Fix: delete account-specific caches when an account is removed#12224

Merged
modSpike merged 3 commits intomasterfrom
fix/delete-account-caches
Jul 29, 2025
Merged

[DC-82] Fix: delete account-specific caches when an account is removed#12224
modSpike merged 3 commits intomasterfrom
fix/delete-account-caches

Conversation

@erikjv
Copy link
Contributor

@erikjv erikjv commented Jul 17, 2025

This includes the cache for space images, as well as certain cached network jobs.

@update-docs
Copy link

update-docs bot commented Jul 17, 2025

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@erikjv erikjv force-pushed the fix/delete-account-caches branch from 345c1e6 to 72b9796 Compare July 17, 2025 13:19
@erikjv erikjv requested review from DeepDiver1975 and modSpike July 17, 2025 13:19
@erikjv erikjv requested a review from modSpike July 18, 2025 12:32
@erikjv erikjv force-pushed the fix/delete-account-caches branch from 1b79d9a to 00adcff Compare July 29, 2025 14:35
Copy link
Contributor

@modSpike modSpike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@modSpike modSpike merged commit 972e1d7 into master Jul 29, 2025
5 checks passed
@modSpike modSpike deleted the fix/delete-account-caches branch July 29, 2025 15:07
@DeepDiver1975
Copy link
Member

@erikjv I'd welcome a backport to branch 6 on this one - THX a lot

erikjv added a commit that referenced this pull request Jul 31, 2025
#12224)

* [DC-82] Fix: delete account-specific caches when an account is removed

This includes the cache for space images, as well as certain cached
network jobs.

* Fix job ownership and explicitly stop the SpacesManager

* Move cleaning the job queue into `cleanupForRemoval()`

(cherry picked from commit 972e1d7)
DeepDiver1975 pushed a commit that referenced this pull request Jul 31, 2025
#12239)

[DC-82] Fix: delete account-specific caches when an account is removed (#12224)

* [DC-82] Fix: delete account-specific caches when an account is removed

This includes the cache for space images, as well as certain cached
network jobs.

* Fix job ownership and explicitly stop the SpacesManager

* Move cleaning the job queue into `cleanupForRemoval()`

(cherry picked from commit 972e1d7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants