Skip to content

Comments

[DC-83] Fix: remove any existing ResourceCache directories for accounts#12214

Merged
erikjv merged 1 commit intomasterfrom
fix/resource-cache-leaking
Jul 16, 2025
Merged

[DC-83] Fix: remove any existing ResourceCache directories for accounts#12214
erikjv merged 1 commit intomasterfrom
fix/resource-cache-leaking

Conversation

@erikjv
Copy link
Contributor

@erikjv erikjv commented Jul 11, 2025

Some versions of the client failed to remove the temporary cache
directory on exit, and after a crash the directory would not be removed
either. This can result in multiple GB of cached space images. So clean
this up before creating a new cache.

@erikjv erikjv requested review from DeepDiver1975 and modSpike July 11, 2025 12:52
@update-docs
Copy link

update-docs bot commented Jul 11, 2025

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@erikjv erikjv force-pushed the fix/resource-cache-leaking branch from 602806f to 125fce4 Compare July 11, 2025 13:15
@erikjv erikjv changed the title Fix resource cache leaking Remove any existing ResourceCache directories for accounts Jul 11, 2025
@erikjv erikjv force-pushed the fix/resource-cache-leaking branch from 125fce4 to b70469f Compare July 11, 2025 16:27
Copy link
Contributor

@modSpike modSpike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a link to the corresponding jira issue!

@erikjv erikjv force-pushed the fix/resource-cache-leaking branch from 5909093 to ed8825d Compare July 16, 2025 12:06
@erikjv
Copy link
Contributor Author

erikjv commented Jul 16, 2025

please add a link to the corresponding jira issue!

Done!

@erikjv erikjv requested a review from modSpike July 16, 2025 12:07
Some versions of the client failed to remove the temporary cache
directory on exit, and after a crash the directory would not be removed
either. This can result in multiple GB of cached space images. So clean
this up before creating a new cache.
@erikjv erikjv force-pushed the fix/resource-cache-leaking branch from ed8825d to efaea84 Compare July 16, 2025 12:13
@erikjv erikjv changed the title Remove any existing ResourceCache directories for accounts [DC-83] Fix: remove any existing ResourceCache directories for accounts Jul 16, 2025
@erikjv erikjv merged commit b6e43d9 into master Jul 16, 2025
5 checks passed
@erikjv erikjv deleted the fix/resource-cache-leaking branch July 16, 2025 14:15
erikjv added a commit that referenced this pull request Jul 17, 2025
…ts (#12214)

Some versions of the client failed to remove the temporary cache
directory on exit, and after a crash the directory would not be removed
either. This can result in multiple GB of cached space images. So clean
this up before creating a new cache.

(cherry picked from commit b6e43d9)
DeepDiver1975 pushed a commit that referenced this pull request Jul 18, 2025
…ts (#12225)

* [DC-83] Fix: remove any existing ResourceCache directories for accounts (#12214)

Some versions of the client failed to remove the temporary cache
directory on exit, and after a crash the directory would not be removed
either. This can result in multiple GB of cached space images. So clean
this up before creating a new cache.

(cherry picked from commit b6e43d9)

* doc: add changelog for PR 12214 (#12223)

Add changelog for PR 12214

(cherry picked from commit 8118d05)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants