Merged
Conversation
TheOneRing
force-pushed
the
work/login
branch
4 times, most recently
from
7b2b133 to
759ac0d
Compare
TheOneRing
commented
Sep 4, 2024
TheOneRing
force-pushed
the
work/login
branch
from
759ac0d to
7288e5f
Compare
TheOneRing
force-pushed
the
work/login
branch
4 times, most recently
from
49075dd to
3d0777b
Compare
TheOneRing
force-pushed
the
work/login
branch
2 times, most recently
from
be4b8f3 to
c96f989
Compare
erikjv
requested changes
Sep 19, 2024
TheOneRing
force-pushed
the
work/login
branch
2 times, most recently
from
2e00229 to
e633296
Compare
erikjv
reviewed
Sep 23, 2024
TheOneRing
force-pushed
the
work/login
branch
from
e633296 to
460e322
Compare
| Q_PROPERTY(bool syncNewlyDiscoveredSpaces READ syncNewlyDiscoveredSpaces FINAL CONSTANT) | ||
| Q_PROPERTY(QColor avatarColor READ avatarColor NOTIFY themeChanged) | ||
| Q_PROPERTY(QColor avatarColorChecked READ avatarColorChecked NOTIFY themeChanged) | ||
| Q_PROPERTY(QColor brandedBackgoundColor READ wizardHeaderBackgroundColor CONSTANT) |
Member
There was a problem hiding this comment.
what about dropping 'branded' here? anything in a theme is about branding - right?
erikjv
approved these changes
Sep 24, 2024
Contributor
Author
|
@saw-jan this change broke the tests, please change the tests. |
Member
Thank you for letting us know. we will change the test behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.