Stop synchronisation when behind a captive portal#11567
Merged
TheOneRing merged 7 commits intomasterfrom Aug 21, 2024
Merged
Conversation
Contributor
Author
|
The |
TheOneRing
reviewed
Apr 2, 2024
TheOneRing
reviewed
Apr 2, 2024
erikjv
force-pushed
the
work/pause-sync-behind-captive-portal
branch
3 times, most recently
from
2728dbe to
7dd72f4
Compare
TheOneRing
reviewed
Apr 5, 2024
TheOneRing
reviewed
Apr 5, 2024
TheOneRing
reviewed
Apr 5, 2024
TheOneRing
reviewed
Apr 5, 2024
TheOneRing
reviewed
Apr 5, 2024
TheOneRing
suggested changes
Apr 5, 2024
Contributor
TheOneRing
left a comment
TheOneRing
left a comment
There was a problem hiding this comment.
For a manual testing action, it has quite a heavy impact on the client...
Contributor
|
Brainstorming: We have multiple network information things to test, could it make sense to implement a custom one that wraps the native one and allows overriding values? |
erikjv
force-pushed
the
work/pause-sync-behind-captive-portal
branch
from
7dd72f4 to
f10d5eb
Compare
erikjv
force-pushed
the
work/pause-sync-behind-captive-portal
branch
2 times, most recently
from
03c2325 to
4e85060
Compare
Contributor
|
Please rebase, once done I can start a review. |
erikjv
force-pushed
the
work/pause-sync-behind-captive-portal
branch
from
5b1e182 to
412851f
Compare
TheOneRing
reviewed
Apr 16, 2024
erikjv
force-pushed
the
work/pause-sync-behind-captive-portal
branch
from
412851f to
07efac2
Compare
erikjv
force-pushed
the
work/pause-sync-behind-captive-portal
branch
2 times, most recently
from
8920af8 to
fdde86d
Compare
TheOneRing
suggested changes
Apr 18, 2024
TheOneRing
suggested changes
Apr 18, 2024
erikjv
force-pushed
the
work/pause-sync-behind-captive-portal
branch
2 times, most recently
from
8023f44 to
d178dc3
Compare
TheOneRing
reviewed
Jun 12, 2024
erikjv
force-pushed
the
work/pause-sync-behind-captive-portal
branch
from
d178dc3 to
474a4e4
Compare
TheOneRing
previously approved these changes
Jun 12, 2024
erikjv
force-pushed
the
work/pause-sync-behind-captive-portal
branch
from
3689e81 to
9d8dd74
Compare
erikjv
force-pushed
the
work/pause-sync-behind-captive-portal
branch
from
9d8dd74 to
7c15ca7
Compare
Like we do for when the client is behind a captive portal.
erikjv
force-pushed
the
work/pause-sync-behind-captive-portal
branch
from
7c15ca7 to
888c835
Compare
Contributor
Author
|
See the screenshot in #11533 (comment) |
erikjv
force-pushed
the
work/pause-sync-behind-captive-portal
branch
from
888c835 to
52f3132
Compare
TheOneRing
previously approved these changes
Aug 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #11533