Properly encode scope and prompt items in OAuth URL#11479
Merged
TheOneRing merged 1 commit intomasterfrom Jan 31, 2024
Merged
Conversation
Contributor
|
Changelog pls |
fmoc
reviewed
Jan 18, 2024
erikjv
force-pushed
the
work/fix-url-encoding-in-oauth
branch
from
fb638e0 to
efae1a4
Compare
erikjv
force-pushed
the
work/fix-url-encoding-in-oauth
branch
from
efae1a4 to
cf3d734
Compare
The scope and the prompt items of an OAuth query can be branded and can contain characters that are not valid without encoding them. This change makes sure that those get encoded properly. Fixes: #11472
erikjv
force-pushed
the
work/fix-url-encoding-in-oauth
branch
from
cf3d734 to
52d503f
Compare
Member
|
Tested: #11472 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scope and the prompt items of an OAuth query can be branded and can contain characters that are not valid without encoding them. This change makes sure that those get encoded properly.
Fixes: #11472