Fix badly styled warning/error messages#11470
Merged
TheOneRing merged 1 commit intomasterfrom Jan 30, 2024
Merged
Conversation
TheOneRing
suggested changes
Jan 16, 2024
Contributor
TheOneRing
left a comment
TheOneRing
left a comment
There was a problem hiding this comment.
Please also add before and after screenshots.
| _ui->setupUi(this); | ||
| _ui->warnFrame->hide(); | ||
| _ui->warningIcon->setPixmap(Resources::getCoreIcon(QStringLiteral("warning")).pixmap(_ui->warningIcon->size())); | ||
| _ui->warningFrame->hide(); |
Contributor
There was a problem hiding this comment.
Where is show() called?
Contributor
Author
There was a problem hiding this comment.
line 367, see your comment below
| _ui->warnFrame->show(); | ||
| _ui->warnLabel->setText(msg); | ||
| _ui->warningFrame->show(); | ||
| _ui->warningLabel->setText(QStringLiteral("<html><body><b>%1</b></body></html>").arg(msg)); |
Contributor
There was a problem hiding this comment.
Qt rhichtext might be a bit shorter than full html :)
Some error messages were styled in a way that is not compatible with dark mode. These have now been replaced by unstyled labels, but the warning icon is shown to the left of the message. Fixes: #11412
erikjv
force-pushed
the
work/remove-label-styling
branch
from
3e54fb7 to
d917872
Compare
Member
|
Tested: #11412 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some error messages were styled in a way that is not compatible with dark mode. These have now been replaced by unstyled labels, but the warning icon is shown to the left of the message.
Fixes: #11412