Conversation
TheOneRing
force-pushed
the
work/modal
branch
4 times, most recently
from
2fa3b1f to
7982bde
Compare
This comment was marked as outdated.
This comment was marked as outdated.
TheOneRing
force-pushed
the
work/modal
branch
from
7b89a88 to
155cce7
Compare
TheOneRing
force-pushed
the
work/modal
branch
3 times, most recently
from
33db464 to
8b96f2f
Compare
|
@tbsbdr I built new testpilotcloud builds with the latest changes: |
TheOneRing
force-pushed
the
work/modal
branch
from
8b96f2f to
340835f
Compare
src/gui/settingsdialog.cpp
Outdated
| } | ||
| } | ||
|
|
||
| void SettingsDialog::requestModality(Account *accout) |
There was a problem hiding this comment.
| void SettingsDialog::requestModality(Account *accout) | |
| void SettingsDialog::requestModality(Account *account) |
| // create a widget filling the stacked widget | ||
| // this widget contains a wrapping group box with widget as content | ||
| auto *outerWidget = new QWidget; | ||
| auto *groupBox = new QGroupBox; |
There was a problem hiding this comment.
Could be owned by the widget, couldn't it?
Life cycle wise, at a first glance, I cannot tell where this object is deleted. Should be documented.
There was a problem hiding this comment.
It will get owned by AccountSettings once added to the layout.
There was a problem hiding this comment.
I see. Might be worth adding a short comment.
There was a problem hiding this comment.
Thats how qt works
| Q_PROPERTY(AccountStatePtr accountState MEMBER _accountState) | ||
|
|
||
| public: | ||
| enum class ModalWidgetSizePolicy { Minimum = QSizePolicy::Minimum, Expanding = QSizePolicy::Expanding }; |
There was a problem hiding this comment.
Yes, see the screenshot, if we bloat the login dialog to full-screen it looks horrible.
| QAction *_toggleSignInOutAction; | ||
| QAction *_toggleReconnect; | ||
| // are we already in the destructor | ||
| bool _goingDown = false; |
There was a problem hiding this comment.
So Qt can execute signal handlers if the object is being deleted in parallel?
There was a problem hiding this comment.
We connect to destroyed which can happen if the widget is closed but also when the parent is destroyed.
TheOneRing
force-pushed
the
work/modal
branch
from
340835f to
2c6eba0
Compare
TheOneRing
force-pushed
the
work/modal
branch
from
2c6eba0 to
db1c960
Compare
TheOneRing
force-pushed
the
work/modal
branch
from
db1c960 to
8712138
Compare
|
This will need sophisticated testing. |
|
Tested with
|
4 participants
Setup Wizard / Re-login
Add folder / Space
Fixes: #11304
Fixes: #11032
Fixes: #11208