Provide "restart required" dialog on Windows, too#11442
Merged
TheOneRing merged 1 commit intomasterfrom Jan 17, 2024
Merged
Conversation
TheOneRing
suggested changes
Dec 19, 2023
Contributor
|
Also please add a changelog entry |
Contributor
Author
There are a "no URL dialog" and an error dialog in the NSIS updater class that offers these options but isn't regularly shown apparently. This dialog is shown when the update has been downloaded sucessfully already. We need to think about consolidating all these (partially redundant) dialogs. However, this is outside of this PR's scope, which replaces a specific systray message with a dialog. |
This commit provides a remodeled version of the "Update finished" dialog implemented in #11201.
fmoc
force-pushed
the
work/updatedownloadeddialog
branch
from
b1cdbae to
fd7d80b
Compare
Contributor
|
|
TheOneRing
approved these changes
Jan 17, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit provides a remodeled version of the "Update finished" dialog implemented in #11201.
Fixes #10980.