Remove styling from the warning label in the "Add Folder" dialog#11401
Merged
TheOneRing merged 1 commit intomasterfrom Nov 29, 2023
Merged
Remove styling from the warning label in the "Add Folder" dialog#11401TheOneRing merged 1 commit intomasterfrom
TheOneRing merged 1 commit intomasterfrom
Conversation
The styling caused unreadable warning/error messages when the OS theme was set to dark: the text color would be white, but the background was styled to be white too. The message is still noticable: normally there is no text in the label, so an error or warning message showing up will be noticed. Fixes: #11243
|
Kudos, SonarCloud Quality Gate passed!
|
TheOneRing
approved these changes
Nov 29, 2023
Contributor
TheOneRing
left a comment
TheOneRing
left a comment
There was a problem hiding this comment.
Was that the only occasion where we modified the palette?
Contributor
Author
I haven't checked this yet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The styling caused unreadable warning/error messages when the OS theme was set to dark: the text color would be white, but the background was styled to be white too.
The message is still noticable: normally there is no text in the label, so an error or warning message showing up will be noticed.
Fixes: #11243