Add option to pause synchronization on metered connections#11305
Merged
TheOneRing merged 3 commits intomasterfrom Jan 5, 2024
Merged
Add option to pause synchronization on metered connections#11305TheOneRing merged 3 commits intomasterfrom
TheOneRing merged 3 commits intomasterfrom
Conversation
erikjv
force-pushed
the
work/pause-sync-when-metered
branch
2 times, most recently
from
d50b1a4 to
d06a6f8
Compare
Contributor
Author
|
To test on Windows: Make sure the "Pause..." checkbox is checked (note: since the screenshot was made, the checkbox has been moved to the top of the network settings): 
Check that the account is connected: 
Go to the windows network adapter settings by opening the "Settings" app, then choose "Network & Internet", and click the "Properties" button. This should have a switch to turn the connection to metered: 
Toggling the switch will change the status of the client to indicate it's paused: 
Toggling the switch back should go to the connected state. |
|
Kudos, SonarCloud Quality Gate passed! |
erikjv
force-pushed
the
work/pause-sync-when-metered
branch
from
d06a6f8 to
2afff7b
Compare
TheOneRing
suggested changes
Nov 10, 2023
erikjv
force-pushed
the
work/pause-sync-when-metered
branch
2 times, most recently
from
eb19eee to
1614f19
Compare
TheOneRing
changed the title
TheOneRing
suggested changes
Dec 19, 2023
Contributor
TheOneRing
left a comment
TheOneRing
left a comment
There was a problem hiding this comment.
Please add a changelog entry
TheOneRing
suggested changes
Dec 19, 2023
erikjv
force-pushed
the
work/pause-sync-when-metered
branch
2 times, most recently
from
06188e1 to
5e453ff
Compare
TheOneRing
previously approved these changes
Jan 4, 2024
Contributor
|
Please fix the changelog:
|
erikjv
force-pushed
the
work/pause-sync-when-metered
branch
from
5e453ff to
7e0d30a
Compare
The `QNetworkInformation` will be used in multiple places. Do the loading once before any uses.
Add an advanced configuration setting to pause synchronization when a metered internet connection is detected. When the internet connection is metered, and the user chooses to force-sync a folder, they will now be asked if they are sure that they want to do this. Fixes: #4808
erikjv
force-pushed
the
work/pause-sync-when-metered
branch
from
612e416 to
bbfb8fe
Compare
TheOneRing
approved these changes
Jan 5, 2024
Member
|
Tested: #4808 (comment) |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.