Conversation
…rver Conflicts: owncloud-android-library src/com/owncloud/android/ui/activity/Preferences.java
annotated todos
|
@davivel before finishing this PR: does it have chances to get integrated? |
|
👍 👍 👍 |
|
@davivel ping. This PR could also then be a starting point to get a real 2way sync for certain folders? |
| <!-- | ||
| ownCloud Android client application | ||
|
|
||
| Copyright (C) 2012 Bartek Przybylski |
|
Mmm, I don't get it works. My last try was setting as folder to observer the one where Telegram stores the images, and tried both to add an image there and to modify an existing one. None of them triggered and upload. Still didn't see the code, will have a look right now. |
| </receiver> | ||
|
|
||
| <service android:name=".services.observer.FileObserverService" /> | ||
| <service android:name=".services.observer.InstantUploadFolderObserverService"/> |
There was a problem hiding this comment.
I'd rather add functionality to FileObserverService instead of adding a new Service to the app. There are too many services right now.
| @Override | ||
| public void onCreate() { | ||
| // TODO start Observer for each stored Entry | ||
| File sdcard = new File("/mnt/sdcard/DCIM/Camera/"); |
There was a problem hiding this comment.
The path to the SD Card should not be hardcoded. Probably we'll need using several methods from https://developer.android.com/reference/android/os/Environment , with different paths depending on Android version.
|
OK, I read the code, now I see why it was not working for me. I will follow in #744 |
|
|
||
| if (preference.saveAll()){ | ||
| Intent preferencesIntent = new Intent(MainApp.getAppContext(), Preferences.class); | ||
| startActivity(preferencesIntent); |
There was a problem hiding this comment.
This breaks the flow of the app. Instead of starting again the Preference activity, this block should just call finish(); the app will be back to the activity that started this one (that is Preference).
|
Hi guys, sorry to bother you, I found out about your discussion and this is exacly what i expect owncloud to do. How can i apply your changes on my android ? Thanks for your contribution ! :D |
|
@nayessiva77 , sorry, but I'm afraid this is not working yet. |
|
damned... |
|
This has been partially subsumed by #1783 . Issue #744 will remain open, but this code will strongly conflict with master, so I'm sorry, but need to be closed. @nayessiva77 , not sure if it will cover all your use case, but maybe you want to give a try to version 2.1.1 just-released. You will be able to select your favorite camera folder to observe for new pictures or videos in it. |
6 participants
This allows to choose any folder on the phone to sync in one direction to owncloud, just like the instant upload does this for images.
This can fix the problem of not using the correct NEW_PHOTO Action and it can also help to "backup" important folders (like WhatsApp Images).