make rootpath and incpath consts for apr_filepath_root#3270
Merged
marcstern merged 1 commit intoowasp-modsecurity:v2/masterfrom Oct 4, 2024
Merged
make rootpath and incpath consts for apr_filepath_root#3270marcstern merged 1 commit intoowasp-modsecurity:v2/masterfrom
marcstern merged 1 commit intoowasp-modsecurity:v2/masterfrom
Conversation
…ncompatible pointer type
|
marcstern
approved these changes
Oct 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
In
standalone/config.c:rootpathandincpathinto const char (rather than just char)rootpathwhere it was being written to, by another char,configfilepathwhy
Avoids apr_filepath_root function to which these are passed throwing an "incompatible pointer type" warning/error (up to gcc13 it is a warning, from gcc14 an error).
references
Fixes #3173