Fix: lmdb regex match on non-null-terminated string#2985
Merged
martinhsv merged 1 commit intoowasp-modsecurity:v3/masterfrom Sep 18, 2023
Merged
Fix: lmdb regex match on non-null-terminated string#2985martinhsv merged 1 commit intoowasp-modsecurity:v3/masterfrom
martinhsv merged 1 commit intoowasp-modsecurity:v3/masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old code was providing the pointer from the lmdb API directly to the regex search function. The pointer points to a correct sequence of bytes for the key, but it is not null terminated.
This issue would primarily affect lmdb match scenarios where the ending of the key would affect the search -- for example if the regular expression used an end-anchor ('$').