Fix memory leaks in ValidateSchema#2479
Closed
martinhsv wants to merge 1 commit intoowasp-modsecurity:v3/dev/3.1-experimentalfrom
martinhsv:v3/dev/3.1-experimental
Closed
Fix memory leaks in ValidateSchema#2479martinhsv wants to merge 1 commit intoowasp-modsecurity:v3/dev/3.1-experimentalfrom martinhsv:v3/dev/3.1-experimental
martinhsv wants to merge 1 commit intoowasp-modsecurity:v3/dev/3.1-experimentalfrom
martinhsv:v3/dev/3.1-experimental
Conversation
Contributor
|
Merged! thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses the 4th one raised in #2469 .
The main change here is to move the pointers to the three xml api objects to the evaluate function as function-scope stack variables. At each stage in the function where a return may occur, all so-far-relevant xmlSchemaFree functions are called to clean up allocated memory.
Some additional memory leak scenarios have been addressed. For examples (transaction->m_xml->m_data.doc == NULL) and (transaction->m_xml->m_data.well_formed != 1). These two in particular have been dealt with by performing the checks at the beginning of the function.