Fix memory leak of ValidateDTD's dtd object#2478
Closed
martinhsv wants to merge 1 commit intoowasp-modsecurity:v3/dev/3.1-experimentalfrom
martinhsv:v3/dev/3.1-experimental
Closed
Fix memory leak of ValidateDTD's dtd object#2478martinhsv wants to merge 1 commit intoowasp-modsecurity:v3/dev/3.1-experimentalfrom martinhsv:v3/dev/3.1-experimental
martinhsv wants to merge 1 commit intoowasp-modsecurity:v3/dev/3.1-experimentalfrom
martinhsv:v3/dev/3.1-experimental
Conversation
zimmerle
reviewed
Dec 16, 2020
Contributor
zimmerle
left a comment
zimmerle
left a comment
There was a problem hiding this comment.
All perfect! Thank you! Merged!
| class ValidateDTD : public Operator { | ||
| class XmlDtdPtrManager { | ||
| public: | ||
| /** @ingroup ModSecurity_Operator */ |
Contributor
There was a problem hiding this comment.
This marking is further used by doxygen, in order to place this class under the operators sub class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses the memory leak listed as 3) in #2469 .
With this pull request, xmlParseDTD() continues to be called for each call of evaluate().
However, the dtd pointer is now no longer a member variable of ValidateDTD. It is held indirectly by a resource-managing object that is itself a stack variable. The resource-managing object then ensures that xmlFreeDtd() when the stack variable goes out of scope and is destructed.