This repository was archived by the owner on Apr 29, 2025. It is now read-only.
refactor(relativeCoords): allow passing full rotation#703
Merged
thelindat merged 3 commits intooverextended:masterfrom Feb 12, 2025
Merged
refactor(relativeCoords): allow passing full rotation#703thelindat merged 3 commits intooverextended:masterfrom
thelindat merged 3 commits intooverextended:masterfrom
Conversation
added 2 commits
February 1, 2025 19:07
Allow passing a full rotation (vector3) to get the relative coords. Usefull if the entity is rotated on other axis than just vertical. This prevent to use a vector4 as first arg though.
Member
Check if coords.w exists, rotation is a vector3, and offset is defined. |
Contributor
Author
Not sure if it's good to rename params in overlads but at least it's explicit like this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow passing a full rotation (vector3) to get the relative coords.
Usefull if the entity is rotated on other axis than just vertical.
This prevent to use a vector4 as first arg though.