This repository was archived by the owner on Apr 29, 2025. It is now read-only.
fix(marker): logical error when setting faceCamera#686
Merged
thelindat merged 1 commit intooverextended:masterfrom Jan 19, 2025
Merged
fix(marker): logical error when setting faceCamera#686thelindat merged 1 commit intooverextended:masterfrom
thelindat merged 1 commit intooverextended:masterfrom
Conversation
Collaborator
|
This looks like a similar logic error as #672. Could you update your logic to match the formatting of the feedback in that PR with a single line instead of these additional if blocks please? |
NotSomething0
force-pushed
the
patch-1
branch
from
7a1faf4 to
d9b42a7
Compare
Contributor
Author
|
Updated, I left the boolean check instead of just checking for nil since DrawMarker expects a boolean and the game doesn't care what you pass as a truthy value as long as it isn't |
jag3dagster
reviewed
Jan 16, 2025
Due to the way boolean values were being assigned, faceCamera would always evaluate to true because of its default value. This change fixes the logical error and ensures boolean properties are properly set.
NotSomething0
force-pushed
the
patch-1
branch
from
d9b42a7 to
fe91c8e
Compare
jag3dagster
reviewed
Jan 16, 2025
Collaborator
jag3dagster
left a comment
jag3dagster
left a comment
There was a problem hiding this comment.
Looks good to me @thelindat
abdel1touimi
pushed a commit
to SaharaScripters/ox_lib
that referenced
this pull request
Jan 26, 2025
Due to the way boolean values were being assigned, faceCamera would always evaluate to true because of its default value. This change fixes the logical error and ensures boolean properties are properly set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the way boolean values were being assigned, faceCamera would always evaluate to true because of its default value. This change fixes the logical error and ensures boolean properties are properly set.