This repository was archived by the owner on Apr 29, 2025. It is now read-only.
tweak(resource/cache): update seat cache on vehicle change#679
Merged
thelindat merged 1 commit intooverextended:masterfrom Jan 16, 2025
Merged
tweak(resource/cache): update seat cache on vehicle change#679thelindat merged 1 commit intooverextended:masterfrom
thelindat merged 1 commit intooverextended:masterfrom
Conversation
jag3dagster
reviewed
Jan 16, 2025
Collaborator
jag3dagster
left a comment
jag3dagster
left a comment
There was a problem hiding this comment.
Seems like a reasonable scenario to cover and the code looks straightforward enough @thelindat
abdel1touimi
pushed a commit
to SaharaScripters/ox_lib
that referenced
this pull request
Jan 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, seat cache event listeners will be triggered all the time when the player's vehicle changes. This is useful in scenarios where the player doesn't exit the vehicle, but we switch their vehicle and warp them into the same seat index, and we want to listen to the seat event to perform specific actions. Previously, seat listeners were not being triggered because the cached seat value stayed the same.