Skip to content
This repository was archived by the owner on Apr 29, 2025. It is now read-only.

fix(progress): playEnter arg for scenarios in progress bar#671

Merged
thelindat merged 2 commits intooverextended:masterfrom
Vyast:master
Jan 17, 2025
Merged

fix(progress): playEnter arg for scenarios in progress bar#671
thelindat merged 2 commits intooverextended:masterfrom
Vyast:master

Conversation

@Vyast
Copy link
Contributor

@Vyast Vyast commented Nov 17, 2024

  • Fixes the "playEnter" arg for TaskStartScenarioInPlace animations in progress bar

Previously, anim.playEnter would be forced to true even if the value being passed in was set to false. Now, playEnter will default to true if no value is given, otherwise it will be set to the correct boolean value.

@Vyast Vyast changed the title Fix "playEnter" arg for progress bar scenario animations fix(progress): playEnter arg for scenarios in progress bar Nov 26, 2024
Copy link
Collaborator

@jag3dagster jag3dagster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic checks out for this one too @thelindat, same as #672

@thelindat thelindat merged commit 93e40ac into overextended:master Jan 17, 2025
abdel1touimi pushed a commit to SaharaScripters/ox_lib that referenced this pull request Jan 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants