Skip to content
This repository was archived by the owner on Apr 29, 2025. It is now read-only.

fix(server/vehicle) Delete vehicle entity on respawn, not delete from DB#211

Merged
thelindat merged 1 commit intooverextended:mainfrom
Alexr03:fix/vehicle-respawn-fix
Nov 14, 2024
Merged

fix(server/vehicle) Delete vehicle entity on respawn, not delete from DB#211
thelindat merged 1 commit intooverextended:mainfrom
Alexr03:fix/vehicle-respawn-fix

Conversation

@Alexr03
Copy link
Contributor

@Alexr03 Alexr03 commented Nov 14, 2024

Currently, when calling vehicle.respawn(...) if the entity of the vehicle currently exists, it will attempt to delete the vehicle from the database rather than delete the entity.

@Alexr03 Alexr03 changed the title fix(server/vehicle) Delete vehicle entity, not vehicle from DB fix(server/vehicle) Delete vehicle entity on respawn, not delete from DB Nov 14, 2024
@CeebDev
Copy link
Contributor

CeebDev commented Nov 14, 2024

@CeebDev
Copy link
Contributor

CeebDev commented Nov 14, 2024

Ho, i see, DeleteVehicle is also the imported method from db

So either rename the method in db.ts and modify it in all import or just use DeleteEntity

Imo the best is to rename the method to avoid conflict with native name

@Alexr03
Copy link
Contributor Author

Alexr03 commented Nov 14, 2024

Its not really conflicting with that native, since it doesn't exist on the server, DeleteVehicle is a client-side native.

@thelindat thelindat merged commit 0360bb5 into overextended:main Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants