This repository was archived by the owner on Apr 29, 2025. It is now read-only.
fix(server/player/class): Incriment active group count in correct order#209
Merged
thelindat merged 1 commit intooverextended:mainfrom Nov 13, 2024
simsonas86:main
Merged
fix(server/player/class): Incriment active group count in correct order#209thelindat merged 1 commit intooverextended:mainfrom simsonas86:main
thelindat merged 1 commit intooverextended:mainfrom
simsonas86:main
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a player disconnects/logs out while having an
activeGroupthegroupName:activeCountwas getting decremented correctly, but when connecting afterwards it misses an increment due to it checking foractiveGroupand attempting to increment beforeactiveGroupgets set in the log in process.This seems to fix it.