Skip to content

Remove module and browser conditions#3935

Merged
Jarred-Sumner merged 3 commits intomainfrom
dave/remove-browser
Aug 3, 2023
Merged

Remove module and browser conditions#3935
Jarred-Sumner merged 3 commits intomainfrom
dave/remove-browser

Conversation

@paperclover
Copy link
Copy Markdown
Contributor

@paperclover paperclover commented Aug 3, 2023

What does this PR do?

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

because i said so

closes #2357
closes #3371
closes #1350

@paperclover paperclover changed the title fix astro compiler Remove module and browser conditions Aug 3, 2023
@Jarred-Sumner Jarred-Sumner merged commit aaaaf74 into main Aug 3, 2023
@Jarred-Sumner Jarred-Sumner deleted the dave/remove-browser branch August 3, 2023 01:46
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 3, 2023

@dylan-conway 2 files with test failures on linux-x64:

  • test/bundler/bundler_browser.test.ts
  • test/js/node/fs/fs.test.ts

View test output

#89827891f0d4cbf314b3697cc515763bc4e1ef5d

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 3, 2023

@dylan-conway 3 files with test failures on linux-x64-baseline:

  • test/bundler/bundler_browser.test.ts
  • test/js/node/fs/fs.test.ts
  • test/js/third_party/prisma/prisma.test.ts

View test output

#89827891f0d4cbf314b3697cc515763bc4e1ef5d

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 3, 2023

@dylan-conway 3 files with test failures on bun-darwin-aarch64:

  • test/bundler/bundler_browser.test.ts
  • test/js/bun/net/socket.test.ts
  • test/js/bun/test/test-test.test.ts

View test output

#89827891f0d4cbf314b3697cc515763bc4e1ef5d

trnxdev pushed a commit to trnxdev/bun that referenced this pull request Aug 9, 2023
* fix astro compiler

* clean this up

* Update options.zig

---------

Co-authored-by: Dylan Conway <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants