Skip to content

🍻 feat: Add signature verification to update process#86

Merged
jobs62 merged 3 commits intomainfrom
feat/sign
Mar 9, 2026
Merged

🍻 feat: Add signature verification to update process#86
jobs62 merged 3 commits intomainfrom
feat/sign

Conversation

@jobs62
Copy link
Copy Markdown
Contributor

@jobs62 jobs62 commented Mar 3, 2026 •
edited
Loading

Description

Add artifact signature and verification for octl.

NOT TESTED as it would require to make a release.

Type of Change

Please check the relevant option(s):

  • 🐛 Bug fix
  • ✨ New feature
  • 🧹 Code cleanup or refactor
  • 📝 Documentation update
  • 🔧 Build or CI-related change
  • 🔒 Security fix
  • Other (specify):

How Has This Been Tested?

Please describe the test strategy:

  • Manual testing
  • Unit tests
  • Integration tests
  • Not tested yet

Checklist

  • I have followed the Contributing Guidelines
  • I have added tests or explained why they are not needed
  • I have updated relevant documentation (README, examples, etc.)
  • My changes follow the Conventional Commits specification
  • My commits include appropriate Gitmoji

@jobs62 jobs62 force-pushed the feat/sign branch 5 times, most recently from a6d8650 to b2d3492 Compare March 3, 2026 15:23
@jobs62 jobs62 added the kind/feature New feature or request label Mar 3, 2026
@jobs62 jobs62 marked this pull request as ready for review March 3, 2026 15:30
jfbus
jfbus reviewed Mar 3, 2026
View reviewed changes
jfbus
jfbus reviewed Mar 3, 2026
View reviewed changes
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 9, 2026 •
edited
Loading

Binary size: 30.3MB => 39.1MB (change +8936KB, +28.7%) 😭

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 9, 2026 •
edited
Loading

WARNING : Differences in reference doc 🤔

diff --git a/docs/reference/octl_update.md b/docs/reference/octl_update.md
index 0602210..f6a86ac 100644
--- a/docs/reference/octl_update.md
+++ b/docs/reference/octl_update.md
@@ -12 +12,3 @@ octl update [flags]
-  -h, --help   help for update
+  -h, --help                            help for update
+      --ignore-digest-verification      Ignore digest verification for the update
+      --ignore-signature-verification   Ignore signature verification for the update (default true)
[...]
More... 
[...]

jfbus
jfbus reviewed Mar 9, 2026
View reviewed changes
@jobs62 jobs62 changed the title 🍻 draft(feat): Add signature verification to update process 🍻 feat: Add signature verification to update process Mar 9, 2026
@jobs62 jobs62 requested a review from jfbus March 9, 2026 13:48
jfbus
jfbus reviewed Mar 9, 2026
View reviewed changes
@jobs62 jobs62 requested a review from jfbus March 9, 2026 15:05
@jobs62 jobs62 force-pushed the feat/sign branch 2 times, most recently from 0be9a18 to fa6fc8e Compare March 9, 2026 15:30
jfbus
jfbus previously approved these changes Mar 9, 2026
View reviewed changes
@jobs62 jobs62 merged commit edca8ae into main Mar 9, 2026
7 checks passed
@jobs62 jobs62 deleted the feat/sign branch March 9, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfbus jfbus jfbus approved these changes

Assignees

No one assigned

Labels

kind/feature New feature or request

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jobs62 @jfbus