Skip to content

Commit c48392e

Browse files
committed
Pin the Windows suite to the pack's Node 24.18.0 and keep the raw output of a test file that exits without a failing assertion
Node 24.19.0 and later abort when a better-sqlite3 build made against their headers collects a prepared statement (nodejs/node#65446), which ended eleven test files with exit code 134 after every test had passed. The Windows runtime pack is built with Node 24.18.0, so the suite now runs on that version. A file that exits non-zero with no failing assertion now records the end of its output so the cause is visible.
1 parent 705e1bf commit c48392e

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

‎.github/scripts/run-suite-files.mjs‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,8 @@ const runFile = (file) => new Promise((resolve) => {
7979
pass: count("pass"), fail: count("fail"), skipped: count("skipped"), failedTests: [...new Set(failed)],
8080
failures: failures(output),
8181
stuck, tail: timedOut ? output.slice(-2500) : "",
82+
// A file that exits non-zero with no failing assertion (a native abort) leaves its reason only in the raw output.
83+
outputTail: code !== 0 && !timedOut ? output.slice(-4000) : "",
8284
firstFailures: code === 0 ? "" : [...output.matchAll(/^\s*not ok \d+ - [\s\S]*?(?=^\s*(?:# Subtest|ok \d+|not ok \d+|1\.\.))/gm)].slice(0, 3).map((m) => m[0].slice(0, 1500)).join("\n----\n") || output.slice(-1500),
8385
})
8486
})

‎.github/workflows/desk-windows-suite.yml‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,8 @@ jobs:
4141
- name: Set up Node
4242
uses: actions/setup-node@v4
4343
with:
44-
node-version: "24"
44+
# The Windows runtime pack is built with Node 24.18.0 (desk-mcp-tests.yml, win32-x64-node-137). Node 24.19.0 and later abort when a better-sqlite3 build made against their headers collects a prepared statement (nodejs/node#65446, WiseLibs/better-sqlite3#1515), so this suite pins the version the pack ships with.
45+
node-version: "24.18.0"
4546
cache: "npm"
4647
cache-dependency-path: plugins/desk/mcp/package-lock.json
4748

0 commit comments

Comments
 (0)