Repository navigation
Commit ade9df6
authored
Make Desk and its test suite work for a standard Windows user, and gate pull requests on it (#175)
* Record every failed test and the stuck process tree in the Windows suite results, and recognize 8.3 temp spellings in the test-state guard
* Resolve the nearest existing ancestor of a card path in the task-status guard, and add an only filter to the Windows suite run
* Fold in the stdio admission fix from #149: the activation-config tests use the shared real MCP client and wait for admission
* Drop the #149 changelog fragment; this branch carries its own
* WIP: probe, desk-relative paths with forward slashes
* Spell desk paths with forward slashes, find SystemRoot in any case, and fix test portability for env, file URLs and path separators
* Skip POSIX-only mode and shebang tests on Windows with named reasons, and make path expectations platform-correct
* Skip re-protecting a Windows path this process already verified while its identity and change time are unchanged
* Match Windows worktree paths from Git to the desk's own spelling in workspace tidy, and read the boot hook path with fileURLToPath in its test
* Open workspace claims and compare receipt paths in the platform's own spelling
* Fix Windows path spellings and portability across tidy, shell-git, coverage, docs and script checks
* Compare worktree paths by spelling only, so a symlinked claim path is still refused, and skip the POSIX-mode refresh check on Windows
* Add the workspace tidy changes to the changelog fragment
* Pin the Windows suite to the pack's Node 24.18.0 and keep the raw output of a test file that exits without a failing assertion
Node 24.19.0 and later abort when a better-sqlite3 build made against their headers collects a prepared statement (nodejs/node#65446), which ended eleven test files with exit code 134 after every test had passed. The Windows runtime pack is built with Node 24.18.0, so the suite now runs on that version. A file that exits non-zero with no failing assertion now records the end of its output so the cause is visible.
* Fix Windows behavior in the index, search pins, folder cleanup, archive links and the workspace watcher, and make the tests expect forward-slash desk paths
On Windows the refs graph and the search pin prefixes were keyed with backslashes, so planning, doing and feedback docs never linked to their task and pinned iterations never matched. A failed move or archive left an empty folder behind because Node returns the first folder it made with a \\?\ prefix that never matched the path being cleaned up. Archiving a task whose task.md is a symlink compared a walked path with a real path and refused safe archives when the spellings differed. The workspace watcher watched the desk root under an 8.3 short name, which makes libuv abort the whole controller process. The runtime test-state guard did not recognize 8.3 temp folders. Tests now expect the forward-slash spelling Desk uses, set USERPROFILE with HOME on Windows, accept EPERM for a rename onto a directory, and skip the one test that seeds the reserved file name con.md.
* Add the index and watcher changes to the changelog fragment
* Fold in the guard fixes: absolute Windows card paths, MSYS and Cygwin paths in the Bash guard, one spelling in denials, and test portability
* Make three tests wait for what they assert on, and run the elevated mode only when asked
* Find short and long spellings of the temp folder in the runtime test-state guard, keep Git on the PATH of isolated Windows sessions, and skip the POSIX-only Node discovery tests on Windows
* Skip the native warm-up on Windows, fix the extended-length mkdir comparison, and keep PowerShell's module cache and Git on the isolated Windows session's environment
* Run the Windows suite on Node 24.18.0 so better-sqlite3 compiles against safe headers, and drop the Windows warm-up skip that only hid the crash
* Skip the native warm-up on Windows again: it still ends servers with an access violation on Node 24.18.0 headers
* Put the server's stderr first in the admission status and activation test failures, and give the answer-time bound a Windows runner margin
* Watch the long spelling of a Windows desk root so libuv does not abort on an 8.3 short name, and run ten concurrency rounds on Windows
* Close the index database handle when opening it fails, so Windows can move a corrupt index aside
* Fold in the admission engineer's test portability fixes: Git on the PATH, USERPROFILE, path separators, POSIX-only skips and Windows time margins
* Make the Windows-failing tests portable: USERPROFILE for the home lookup, slash-spelled desk paths, a node.exe shim, named pipes, and a Windows endpoint check that rejects a missing endpoint
* Accept jq's CRLF line ending in the session-start test, and name the running processes when a fixture folder cannot be removed on Windows
* Normalise jq's line ending for the second start-hook comparison, and list what is left when a fixture folder cannot be removed
* Treat a Windows fixture folder that is empty but still delete-pending as removed
* Say why a fixture folder with files left cannot be removed on Windows
* Accept a Windows fixture folder left holding only empty folders as removed
* Share one PowerShell run between identical concurrent protection requests, and fix the last standard-mode test portability failures
* Make the Windows suite job fail when any test file fails or times out, prove it with a synthetic failing run, and run the suite on pull requests
* Protect the private feedback store on every open, without the skip for already verified paths
* Port the improvement, sign-off, shell-git and derive tests to Windows, and fix the crew-desk card prefix
The improvement tools passed the card library a person prefix built with path.relative, which is desks\alias on Windows, and the library only accepts desks/alias, so a crew desk could not open or claim cards on Windows. The prefix now uses the same slash spelling as every other desk path.
The tests that build their own environment now carry SystemRoot through osEnv, expect slash desk paths, read POSIX-spelled fixtures through the host's own path rules, and skip the few checks that depend on POSIX permission bits or ENOTDIR with the exact Windows limit named. The hook dependency test now makes its cache unwritable with a path under a regular file, because /dev/null/x is creatable on Windows.
* Treat a redirect to /dev/null as no file write on Windows, and finish the path spellings in the derive and fm tests
Git Bash on Windows resolves a redirect to /dev/null into D:\dev\null, which the write filter no longer recognised, so the factory would have recorded a file write for every quiet command. The filter now checks the word as typed. The tests state PowerShell paths as Windows paths and the other fixtures through the host's own path rules.
* Make the factory loop tests portable to Windows and fix two Windows defects: person prefixes spelled with forward slashes, and the Claude CLI found as claude.exe
The loop, route, mirror, evaluator and reconcile tests built an environment without SystemRoot, so every protected write failed on Windows. They now use osEnv. Fixture paths in the binding tests are spelled as absolute paths for the platform, and tests that need chmod, an execute bit or a shell script standing in for git are skipped on Windows with the reason.
The crew person prefix was built with path.relative, giving desks\sam on Windows, which the improvement card folder refuses. It now uses deskRelativePath. findAgentCli looked only for claude, so a Windows user's claude.exe was never found; it now looks for claude.exe on Windows.
* Make the last two factory loop test cases portable to Windows: the repository fake splits on the platform separator, and the dangling-link lock case is left out on Windows
* Spell two more card paths with forward slashes, and add the new product fixes to the changelog fragment
* Cover the paths the coverage gate flagged, and finish the forward-slash expectations for crew-desk cards
* Fix merged task_signoff test paths
* Add a Windows suite aggregate job that counts per-file results
* Make the new main tests and the cleanup index portable to Windows; wait longer for a server's late writes before removing a test fixture
* Make private_view tests portable to Windows; cover refs.js fully and drop its unreachable branches
* Wait for a Windows lock file whose deletion is pending instead of failing on EPERM
* Remove the activation test fixture again when the server wrote late, since Node's retries do not re-list the folder
* Give the feedback preview-version tests the Windows system variables
* Give each Windows test file 30 minutes: the slowest takes about 20 with a protected write behind every factory call
* Wait for the first flush's lock in the concurrent-flush test instead of a fixed 50 ms
* Allow a second for a Windows answer while admission is busy: 506 ms failed a 500 ms bound on a loaded runner
* Windows suite: review fixes (verdict checks, median answer times, bounded lock wait, declared skips)
* Windows suite: make two new main tests host-path and slow-write safe
* Artifact scripts test: generous budgets where the test is about output folders
* Windows suite: tighter answer cap, no-test files fail the verdict, bounded lock retry for improvement cards1 parent 6faf914 commit ade9df6
163 files changed
Lines changed: 1838 additions & 715 deletions
File tree
- .github
- scripts
- workflows
- plugins/desk
- changelog.d
- mcp/src
- coverage
- db
- desk
- factory
- indexer
- readiness
- runtime
- tools
- util
- scripts
- tests/desk/mcp/__tests__
- artifacts
- coverage
- db
- desk
- docs
- factory
- indexer
- launch
- readiness
- runtime
- scripts
- snapshots
- tools
- util
- tools/unused-code
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
| 9 | + | |
8 | 10 | | |
9 | 11 | | |
10 | 12 | | |
11 | 13 | | |
12 | 14 | | |
13 | | - | |
| 15 | + | |
14 | 16 | | |
15 | | - | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
16 | 20 | | |
17 | 21 | | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
25 | 44 | | |
26 | 45 | | |
27 | 46 | | |
28 | 47 | | |
29 | 48 | | |
30 | 49 | | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
31 | 60 | | |
32 | 61 | | |
33 | 62 | | |
34 | | - | |
| 63 | + | |
35 | 64 | | |
36 | 65 | | |
37 | 66 | | |
38 | 67 | | |
39 | 68 | | |
40 | | - | |
| 69 | + | |
| 70 | + | |
41 | 71 | | |
42 | 72 | | |
43 | 73 | | |
| |||
46 | 76 | | |
47 | 77 | | |
48 | 78 | | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
49 | 83 | | |
50 | 84 | | |
51 | 85 | | |
52 | 86 | | |
53 | 87 | | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
54 | 106 | | |
55 | 107 | | |
56 | 108 | | |
57 | 109 | | |
58 | 110 | | |
59 | 111 | | |
60 | | - | |
| 112 | + | |
61 | 113 | | |
62 | 114 | | |
63 | 115 | | |
| |||
72 | 124 | | |
73 | 125 | | |
74 | 126 | | |
75 | | - | |
76 | | - | |
| 127 | + | |
| 128 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
8 | 9 | | |
9 | 10 | | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
10 | 17 | | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
11 | 28 | | |
12 | 29 | | |
13 | 30 | | |
| |||
21 | 38 | | |
22 | 39 | | |
23 | 40 | | |
| 41 | + | |
| 42 | + | |
24 | 43 | | |
25 | 44 | | |
26 | 45 | | |
27 | | - | |
| 46 | + | |
28 | 47 | | |
29 | 48 | | |
30 | 49 | | |
31 | 50 | | |
32 | 51 | | |
| 52 | + | |
| 53 | + | |
33 | 54 | | |
34 | 55 | | |
35 | 56 | | |
36 | 57 | | |
37 | 58 | | |
38 | 59 | | |
39 | | - | |
| 60 | + | |
| 61 | + | |
40 | 62 | | |
41 | 63 | | |
42 | 64 | | |
| |||
55 | 77 | | |
56 | 78 | | |
57 | 79 | | |
58 | | - | |
| 80 | + | |
59 | 81 | | |
60 | 82 | | |
| 83 | + | |
61 | 84 | | |
62 | 85 | | |
63 | 86 | | |
64 | 87 | | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
69 | 93 | | |
70 | 94 | | |
71 | 95 | | |
| |||
81 | 105 | | |
82 | 106 | | |
83 | 107 | | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
0 commit comments