Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-6946 Fix manage collection items page sometimes showing unrelated works instead of bookmarks #5114

Merged
merged 3 commits into from
Mar 26, 2025

Conversation

Bilka2
Copy link
Contributor

@Bilka2 Bilka2 commented Mar 26, 2025

Issue

https://otwarchive.atlassian.net/browse/AO3-6946

Purpose

Make the manage collection items page not show works instead of bookmarks sometimes.

The first commit shows that the test fails without the fix, the third commit shows that the test passes with the fix.

Credit

Bilka

@github-actions github-actions bot added Scope: Tests Only Only changes automated tests or test configuration Awaiting Review labels Mar 26, 2025
@Bilka2 Bilka2 marked this pull request as ready for review March 26, 2025 19:14
@Bilka2 Bilka2 removed the Scope: Tests Only Only changes automated tests or test configuration label Mar 26, 2025
@Bilka2 Bilka2 changed the title AO3-6946 Add failing test for incorrect preload by includes AO3-6946 Fix manage collection items page sometimes showing unrelated works instead of bookmarks Mar 26, 2025
@brianjaustin brianjaustin merged commit 6ce0bb1 into otwcode:master Mar 26, 2025
29 checks passed
@Bilka2 Bilka2 deleted the AO3-6946-broken-scope-again branch March 26, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants