Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-6943 Fix flaky search filtering tests #5101

Conversation

Bilka2
Copy link
Contributor

@Bilka2 Bilka2 commented Mar 16, 2025

Issue

https://otwarchive.atlassian.net/browse/AO3-6943

Purpose

Add some indexing and waiting steps to the search filters features to make sure the dashboard count and its cache are up to date.

Testing Instructions

No manual QA required. Without the fix, 20 test runs resulted in 12 failures. With the fixes 20 test runs result in no failures.

References

PRs with failures:
#5096 https://github.com/otwcode/otwarchive/actions/runs/13869384770/job/38814060572
#5100 https://github.com/otwcode/otwarchive/actions/runs/13865383071/job/38803258894 (with partial fix)

Credit

Bilka

@github-actions github-actions bot added Scope: Tests Only Only changes automated tests or test configuration Awaiting Review labels Mar 16, 2025
@zz9pzza zz9pzza self-requested a review March 16, 2025 14:30
@sarken sarken merged commit 9fadfc6 into otwcode:master Mar 17, 2025
48 of 49 checks passed
@Bilka2 Bilka2 deleted the AO3-6943-intermittent-failures-in-cucumber-features-search-filters branch March 17, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed: Ready to Merge Scope: Tests Only Only changes automated tests or test configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants