AO3-6942 Update page title in admin for spam ban deletion #5100
Conversation
laurasimmons30
force-pushed
the
AO3-6942-update-browser-page-title-during-spam-ban
branch
from
2e98a70 to
2bc82d0
Compare
|
You might want to pick a shorter title for your pull request, because when the commits get squashed during merge, that becomes the new commit message |
laurasimmons30
changed the title
laurasimmons30
changed the title
laurasimmons30
changed the title
features/search/filters.feature
Outdated
| @@ -12,6 +12,7 @@ Feature: Filters | |||
| And I post the work "A Hobbit's Meandering" with fandom "The Hobbit" | |||
| And I post the work "Bilbo Does the Thing" with fandom "The Hobbit, Legend of Korra" | |||
| And I post the work "Roonal Woozlib and the Ferrets of Nimh" with fandom "Harry Potter" | |||
| And it is currently 1 second from now | |||
There was a problem hiding this comment.
There seems to be some flakyness around the works count and bookmarks count links getting populated with the correct number of created works before they're clicked in some tests. I'm not sure this totally fixed it, but worth flagging.
There was a problem hiding this comment.
Have you looked at https://github.com/otwcode/otwarchive/blob/master/features/step_definitions/search_steps.rb#L1C6-L1C37
all indexing jobs have been run ?
There was a problem hiding this comment.
I pulled this text fix out into a separate Jira issue and pull request: #5101
config/locales/views/en.yml
Outdated
| @@ -148,6 +148,7 @@ en: | |||
| caution_html: Are you sure you want to <strong><em>delete</em></strong> all the works and comments created by this user, along with their %{bookmarks} bookmarks, %{series} series, and %{collections} collections? This <strong>cannot be undone</strong>. | |||
| confirm: Are you sure? Remember this will destroy ALL these objects! | |||
| page_heading: Delete Spammer Creations | |||
| page_title: "%{login} - Confirm Deletion of User Creations" | |||
There was a problem hiding this comment.
Please move this to config/locales/controllers/en.yml instead.
There was a problem hiding this comment.
Is that correct? This change is for the text in the browser tab title to be updated, not a controller action message (to my understanding).
example of a different page per the ticket:
otwarchive/config/locales/views/en.yml
Line 159 in 451f0b8
There was a problem hiding this comment.
Yes, because it's getting set in the controller, not in the view. A few of the locales for the page titles accidentally ended up in the wrong file, we have https://otwarchive.atlassian.net/browse/AO3-6924 to fix some of them.
There was a problem hiding this comment.
Ok sounds good! Thanks for the clarification, i will make that update 👍
brianjaustin
changed the title
…r creations page to be dynamic
laurasimmons30
force-pushed
the
AO3-6942-update-browser-page-title-during-spam-ban
branch
from
451f0b8 to
9b340db
Compare
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-6942
Purpose
Updates the page title for
confirm_delete_user_creationpage in admin view to be more dynamic and consistent with other similar page titlesCredit
Laura (she/her)