AO3-6933 Add spam checking to user comments #5099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Has Migrations
EchoEkhi
commented
Mar 13, 2025
| @@ -65,7 +65,7 @@ def by_anonymous_creator? | |||
| validate :check_for_spam, on: :create | |||
|
|
|||
| def check_for_spam | |||
| errors.add(:base, ts("This comment looks like spam to our system, sorry! Please try again, or create an account to comment.")) unless check_for_spam? | |||
| errors.add(:base, ts("This comment looks like spam to our system, sorry! Please try again.")) unless check_for_spam? | |||
There was a problem hiding this comment.
I think I'll leave the i18n to a later ticket
EchoEkhi
commented
Mar 13, 2025
Bilka2
reviewed
Mar 14, 2025
sarken
reviewed
Mar 16, 2025
sarken
reviewed
Mar 16, 2025
sarken
reviewed
Mar 18, 2025
Bilka2
requested changes
Mar 18, 2025
There was a problem hiding this comment.
Thank you for working on this! In addition to addressing my comments, please also update the PUT #update test in settings_controller_spec.rb for the new setting.
As a sidenote, you can use comment.user instead of comment.pseud.user if you prefer; user is delegated to pseud.
db/migrate/20250312233933_add_account_age_threshold_for_comment_spam_check_to_admin_settings.rb
Show resolved
Hide resolved
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
|
Looks like the setting got cached with the wrong (old) value on staging. I will make a note that the migration needs to be applied before the production deploy to prevent this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-6933
Purpose
Testing Instructions
See JIRA ticket
Credit
EchoEkhi