AO3-6129 Rate limit admin login requests #5079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redsummernight
changed the title
gmjimenezc
force-pushed
the
AO3-6129
branch
2 times, most recently
from
7531a43 to
4760395
Compare
|
should i fix the rubocop too? @redsummernight |
Please do! |
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
redsummernight
approved these changes
Feb 25, 2025
redsummernight
added
Reviewed: Ready to Merge
and removed
Coder Has Actioned Review
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-6129
Purpose
What does this PR do?
It rate limits admin login request to 10 max attemps and 5 minutes by default
Credit
warlockmel (she/her)