Hi, Metallicity!

Thank you so much for this pull request. I'm checking in with the Tag Wrangling team about whether they'd like the "Canonical or synonymous" option added, and someone will be along to review the code soon.

In the meantime, I've updated the Jira issue status to In Review, so no one will mistakenly create a duplicate pull request. If you'd like the ability to comment on, assign, and transition issues in the future, you're welcome to create a Jira account! You can just reply here with the account name and we'll set up the permissions for you. (It makes things a bit easier for us on the organizational side if the Full Name on your Jira account either closely matches the name you'd like us to credit in the release notes or includes it in parentheses, e.g. "Nickname (CREDIT NAME).")

Thanks again for contributing! If you have any questions, you can contact us at [email protected].

@sarken I just joined the otwarchive Jira with an account named "Metallicity".

@metallicity Great! I've given your account the permissions I mentioned and updated the issue to assign it to you and add your testing instructions. The Tag Wrangling team has also approved the inclusion of the "Canonical or synonymous" option, so this is ready for review!

I did notice some Reviewdog comments about using the old ts() method when I glanced at the code while updating the Jira issue. If you'd like some info on how to deal with those comments, you can check out our Internationalization (i18n) Standards wiki page.

I moved all the "wrangling status" option labels into en.yml, as well as the more low hanging fruit from the rest of the page. But there are several non-obvious sections on the Tag Search page, particularly the tag types radio button set and the sort by/sort direction drop downs, which I'm not sure have an established i18n convention within the codebase. Regardless, all of those sections are unrelated to the PR itself.

Addressed both comments. Nothing that I wasn't half expecting, I had already gone back and forth on which way set_wrangling_status would be more clear.

Also re-requested you for review, @redsummernight, but feel free to take yourself off if it's better to just leave it with a general "Awaiting Review" tag or something.

Because we're adding a new field to tag index, we'll need to reindex all tags on production when deploying this change by running:

TagIndexer.index_from_db

But I think it may be possible to do wrangling status filtering not by adding a new field, but by checking the existing field merger_id. I'll get back to you on that.

@redsummernight Intuitively, using just the value of canonical and whether merger_id is present seems like it should work fine. It does make the interaction with the original canonical_filter a bit more awkward though, so it struck me as simpler to instead combine things into a single wrangling_status_filter, and then move the wrangling_status case block directly into tag_query.rb.

It should be safe to remove the Needs Reindex label on this PR now, since I reverted all the changes that using merger_id made unnecessary.

@metallicity the wranglers say thank you for this improvement!

@metallicity hi, just popping by from wranglerland to confirm that we wranglers are indeed overjoyed with the improvement! thank you for all the effort you've put into it <3